MailboxesParser

[piernik]

I'm adding mailboxesParser. It sorts mailboxes and fetches special folders like "sent", "inbox", "trash". Tests are in tests\MailboxesParser\. Usage:

$parser = new MailboxesParser($this->mailboxes);
//set language (only pl) for special folders names and mailboxNames
$parser->setLanguage('pl');
//get flat but sorted folders. Folders are ParsedMailbox class
$folders = $parser->getFolders();
//get tree structure of folders
$tree = $parser->getTreeStructure();

[piernik]

I've changed files.

[Slamdunk]

Thanks for the changes.

Still please make the tests pass, and run the PHP-CS-Fixer to apply the code style this library follows.

[piernik]

I said I'm not github fluent. I don't know what that is :) Can't You make it on Your own?

[Slamdunk]

On the bottom of this Pull Request you can see a red cross near continuous-integration/travis-ci/pr.

If you click on the "Details" link you can see that Travis, a continuous integration server, pulled your PR and performed some checks that this library asked Travis to do.

At the time of writing, those checks are done against three different PHP versions, and if you click in each of them you can see what are the failures that are marking your PR as failing.

The first failure I see is:

PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in /home/travis/build/ddeboer/imap/tests/MailboxesParser/MailboxesParserTest.php on line 15

And the second failure I see is that you didn't run the following command:

$ vendor/bin/php-cs-fixer fix --verbose

That fix the coding style of the code you wrote.

Please try to fix those failure: if you need more help I'm here.

[piernik]

About tests - You're using phpunit 6 - I have phpunit 5 globally. It's fixed.

About cs-fixer. This is my output. Don't know what that means.

[Slamdunk]

Vendor binaries must be run from the project root folder. All the necessary dependencies are installed in the project: you should run these once, there is no need for a global PHPUnit installation.

From the imap project repository run these commands:

$ vendor/bin/phpunit
$ vendor/bin/php-cs-fixer fix --verbose

You need both to pass.

[piernik]

I give up. Fix the code on Your own - sorry.

[Slamdunk]

I'm sad that you are giving up.

Though, each new functionality must be well tested and checked. This library is widely used by a lot of users and we must ensure reliability: we can ship code that isn't tested.

I'll leave this PR open: if you ever want to finish it, we'll be thankful.

[piernik]

I did add tests. I don't know what travis wants. You can fetch code and fix it on Your own.

[Slamdunk]

I'm sorry but you can't share a code that isn't proved to be working and expect someone else to fix it.

I can help you if you don't understand the tools, but it is up to you to provide the functionality and its tests, and to prove everything works fine.