OneToManyReader assumes records are sorted by join fields

[rjmackay]

OneToManyReader assumes records are sorted by join fields. For each left row, it iterates over RHS rows until it hits a row which doesn't match. If they're out of order, this means any later RHS rows are ignored.

The relevant code is ~ line 94 of OneToManyReader while ($leftId == $rightId && $this->rightReader->valid()) {

The reader should either not make this assumption, or document it

[Baachi]

Feel free to submit a PR :)

[red-crown]

+1