LyricsX icon indicating copy to clipboard operation
LyricsX copied to clipboard

LyricsX needs to be restarted after each song

Open Ein-Tim opened this issue 1 year ago • 70 comments

Environment

  • macOS Monterey 12.5.1
  • MacBook Air late 2020 (M1)
  • LyricsX version 1.6.3
  • Spotify for macOS (Apple Silicon) 1.1.93.896.g3ae3b4f3

Describe the bug

When I start LyricsX before I start playing a song, LyricsX won't work (=won't show the lyrics). So I start LyricsX while I play a song and it will work. However, after the currently playing song ended and the next one starts, LyricsX again doesn't work and needs to be restarted.

Ein-Tim avatar Sep 08 '22 12:09 Ein-Tim

I got same situation, i belive it's a bug.

RockTraveler avatar Sep 10 '22 02:09 RockTraveler

i got the same issue , need to restart lyricx after every song

arifth avatar Sep 19 '22 05:09 arifth

I have the same problem than @Ein-Tim: macOS 12.6 LyricsX App Store Version 1.6.3 (2350) Spotify para macOS (Intel) 1.1.94.870.gf994cb0b

JosMurray avatar Sep 20 '22 16:09 JosMurray

macOS 12.6 LyricsX App Store Version 1.6.3 iTunes also can't search Lyrics

sahakaori avatar Sep 23 '22 18:09 sahakaori

I have the same issue too macos 12.6 Apple M1

LLuna-a avatar Sep 25 '22 14:09 LLuna-a

@ddddxxx It seems like the author is currently unavailable, and hasn't been responding to any messages sadly. I think almost everyone has this issue no matter which version

rzb-y avatar Sep 28 '22 00:09 rzb-y

i wrote an applescript that restarts it every 15 seconds if anyone interested i can post it

LLuna-a avatar Sep 28 '22 12:09 LLuna-a

@LLuna-a it would be appreciated if you post the scripts. :)

eiche77 avatar Sep 30 '22 03:09 eiche77

@LLuna-a it would be appreciated if you post the scripts. :)

@eiche77 https://github.com/LLuna-a/LyricsX-Temporary-Fix here I published it it's not efficient at the moment I will rework it to simply restart it beginning of a new song

LLuna-a avatar Sep 30 '22 08:09 LLuna-a

also, @eiche77 if you understand the apple script can you help it with the more developed version I couldn't find a way to loop it it just works once and stops

LLuna-a avatar Sep 30 '22 08:09 LLuna-a

any news from the developer? can someone talk to him on telegram?

LLuna-a avatar Oct 10 '22 07:10 LLuna-a

@ddddxxx Can we expect a fix for this issue from your side anytime soon?

Ein-Tim avatar Oct 13 '22 15:10 Ein-Tim

The same issue for me. Ventura beta 11

EraserCN avatar Oct 20 '22 09:10 EraserCN

same

RadioHeadach avatar Nov 03 '22 02:11 RadioHeadach

Same to me

augustido avatar Nov 03 '22 17:11 augustido

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image

LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: https://github.com/ddddxxx/LyricsKit/pull/16

jjaychen1e avatar Nov 07 '22 14:11 jjaychen1e

it seems like the problem is solved thanks to @jjaychen1e edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

LLuna-a avatar Nov 07 '22 17:11 LLuna-a

it seems like the problem is solved thanks to @jjaychen1e edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

It's not merged and released yet, did you test it with your own build? For me, the cached lyrics work fine all the time, only new songs cannot fetch the lyrics. My commit fixes this but has not been merged.

jjaychen1e avatar Nov 07 '22 18:11 jjaychen1e

it seems like the problem is solved thanks to @jjaychen1e edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

It's not merged and released yet, did you test it with your own build? For me, the cached lyrics work fine all the time, only new songs cannot fetch the lyrics. My commit fixes this but has not been merged.

sorry, yes I tried building my own must made a mistake its worth waiting the official merge then cached ones always had worked for me but it cached the first 2 3 ones I opened that's why i thought it worked

LLuna-a avatar Nov 07 '22 18:11 LLuna-a

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image

LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

Gghyy avatar Nov 10 '22 15:11 Gghyy

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Update: I've re-uploaded a universal version so it can work on both Intel and Apple Silicon Macs.

jjaychen1e avatar Nov 10 '22 15:11 jjaychen1e

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

FrankYip1020 avatar Nov 11 '22 06:11 FrankYip1020

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Thank you very much!! That helps me a lot! 😄 😄

Gghyy avatar Nov 11 '22 06:11 Gghyy

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

jjaychen1e avatar Nov 11 '22 06:11 jjaychen1e

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

Thanks a lot, it works on my Mac.

FrankYip1020 avatar Nov 11 '22 06:11 FrankYip1020

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Jechin avatar Nov 11 '22 14:11 Jechin

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

jjaychen1e avatar Nov 11 '22 14:11 jjaychen1e

thanks for new build it works

LLuna-a avatar Nov 11 '22 18:11 LLuna-a

Thank you so much, it works for me!

LightFocus avatar Nov 13 '22 15:11 LightFocus

Thank you so much, it works for me!

does it still work for you? the build from @jjaychen1e stopped working for me after a while

LLuna-a avatar Nov 13 '22 18:11 LLuna-a