Dion Hulse

Results 280 comments of Dion Hulse

This isn't a change that should be needed - WordPress should gracefully handle the object cache being enabled during upgrades. Infact, not only should it not be needed, but the...

The backtick operator is handled by `Generic.PHP.BacktickOperator.Found`: https://github.com/WordPress/plugin-check/blob/54f1eb0142905bf03f80459ea5668d559fad233d/checks/phpcs/plugin-check.xml#L49-L50 Shell exec via #27

Unit tests show that this is a `warning`, I think it should possibly be raised to error.

The code included in https://github.com/WordPress/wporg-code-analysis may be a start here, specifically: https://github.com/WordPress/wporg-code-analysis/blob/trunk/MinimalPluginStandard/Sniffs/OutputEscapingSniff.php

I've gone ahead and migrated it from the Automattic to WordPress github organisation. The package files still need to be updated with the new location.

> @dd32 [said](https://github.com/WordPress/pattern-directory/pull/307), > > > This also has the benefit that searching an English phrase would result in matching an english pattern, and not just returning an empty data...

This modified SQL does result in de-duplicated search: ```diff - SELECT SQL_CALC_FOUND_ROWS wp_posts.ID + SELECT SQL_CALC_FOUND_ROWS MAX( wp_posts.ID ) FROM wp_posts INNER JOIN wp_postmeta ON ( wp_posts.id = wp_postmeta.post_id )...

WordPress contains a compat version of the `str_*` functions for older PHP releases. Any reason this shouldn't be bumped to PHP 8.1 though? (The next version we'll use on WordPress.org)

I should note, that I don't think this is a launch blocker of any form. > Currently, the patterns sent to WordPress sites are those with the internal keyword "Core",...

To simplify the process for setting a priority on the strings, I created https://github.com/GlotPress/GlotPress-WP/issues/1340 & https://github.com/GlotPress/GlotPress-WP/pull/1341