termios-rs icon indicating copy to clipboard operation
termios-rs copied to clipboard

Fix warning about deprecated mem::uninitialized()

Open linkmauve opened this issue 4 years ago • 3 comments

The API to use for this is now mem::MaybeUninit().

linkmauve avatar Jul 16 '20 12:07 linkmauve

You still have Rust 1.13 in the CI, this one is four years old at this point, is this something you want to keep or should I upgrade it to a more sensible baseline? MaybeUninit exists since Rust 1.36, which could be a sensible new baseline.

linkmauve avatar Jul 16 '20 13:07 linkmauve

Hi @linkmauve. This is something I want to do at some point. Supporting four year-old compilers is a feature. I'll just need to make a judgement call of when it's okay to bump the minimum supported version to 1.36. It's likely I could do that soon with a version bump after I have time to sit down and think about it. I'm dealing with a family emergency right now, so I'm just not in the frame of mind to think about it for a while.

dcuddeback avatar Jul 23 '20 02:07 dcuddeback

Hi @dcuddeback. 1.36 is about three years old now, and I think you should be able to merge this now from this point of view. No serious Rust project is compiling on 1.36 now, since almost every other crate has a higher MSRV. If you still don't have time for personal reasons, that's fine, but I just wanted to remind you :).

Noratrieb avatar Jun 18 '22 18:06 Noratrieb