forklift icon indicating copy to clipboard operation
forklift copied to clipboard

Kafka Connector: Consumer Topic + Grouped Topic Support

Open Kuroshii opened this issue 8 years ago • 2 comments

Changes:

  • Index KafkaController instances based on both topic name and the chosen groupId for a topic this way, each different GroupedTopicSources gets it's own underlying KafkaConsumer
  • If class-annotated, a TopicSource is identified by both the default groupId and it's class's name
  • Add tests for the way sources are mapped

I ran all the tests locally and they all eventually passed after a rerun and 2GB of memory. Having another look at our integration tests is a good idea.


Please Review: @seanmrogers @dkessler-sofi @AFrieze

Kuroshii avatar Oct 16 '17 16:10 Kuroshii

@Kuroshii can you add a release note to the README and update the version for release? Thanks

dcshock avatar Dec 03 '17 03:12 dcshock

@Kuroshii is this something that we'd like to get merged in? I'm not familiar enough with the kafka connector to make the assessment.

dcshock avatar Jul 17 '20 03:07 dcshock