angular-img-fallback icon indicating copy to clipboard operation
angular-img-fallback copied to clipboard

main property in bower manifest should point to runnable code

Open thethomaseffect opened this issue 8 years ago • 5 comments

We use main-bower-files with gulp to inject our dependencies into our application and just suffered an outage because the main property in angular-img-fallback's bower points to ES6 code. I'd suggest pointing it towards the transpiled minified version instead.

Until this fix is deployed, the workaround is adding the following to your applications bower file:

"overrides": {
    "angular-img-fallback": {
      "main": "angular.dcb-img-fallback.min.js"
    }
}

thethomaseffect avatar Sep 02 '16 10:09 thethomaseffect

This need to be fixed, it breaks the build process when you use angular-fullstack-generator and took me a lot of time to debug. Just because there are some ES6 fat arrows in the main file.

nhim175 avatar Sep 14 '16 00:09 nhim175

+1 - this broke the gulp-uglify part of my build

jordajm avatar Dec 08 '16 16:12 jordajm

@nhim175 @jordajm can you please share the errors you are getting?

dcohenb avatar Dec 09 '16 10:12 dcohenb

@dcohenb - the error was something like "unrecognized character '>'" - I assume from the ES6 fat arrows as mentioned above. @thethomaseffect's workaround fixed the issue.

jordajm avatar Dec 09 '16 15:12 jordajm

This is a collision with this issue: https://github.com/dcohenb/angular-img-fallback/issues/12 In short, the other one states that the main file should be the unminified version...

dcohenb avatar Dec 18 '16 09:12 dcohenb