setup-node-nvm icon indicating copy to clipboard operation
setup-node-nvm copied to clipboard

Is it possible to specify architecture?

Open javihernandez opened this issue 4 years ago • 3 comments

First of all, thanks for providing such useful action :+1:

This is not an issue but a question. With nvm you can specify the architecture, i.e.:

nvm install 12.16.3 32
nvm use 12.16.3 32

Is this something you're up to support?

javihernandez avatar Nov 09 '20 09:11 javihernandez

Hmm, good question. Haven't had a need for this yet, but if it is useful to you then I'm happy to accept a PR :)

dcodeIO avatar Nov 09 '20 13:11 dcodeIO

That’s not a feature of nvm itself, only nvm-windows.

ljharb avatar Nov 09 '20 16:11 ljharb

That’s not a feature of nvm itself, only nvm-windows.

So true, I've been using nvm on both gnu/linux and windows for years and I'm just realizing it's only available in nvm-windows, never needed this on gnu/linux. Sorry for any confusion.

In our case, we have some legacy code that uses some Windows APIs and by the time of writing it, we still had Windows 7 and Windows 8 around. Recently, we started moving into github actions as CI (before we had our CI spinning up custom vagrant boxes where node 32 was installed via chocolatey), and even though the code was supposed to be ready to run on 64 bit, it still requires some porting work here and there. That's the reason we're still building against node 32 bit on windows.

I totally understand if you don't like the idea of supporting this feature. In the other hand, we can mention in the README that specifying the architecture only works on nvm-windows. i.e.: adding an input field "node-arch" that only works when running on Windows.

@dcodeIO if you're still open to review/accept a PR, I can get to it when I get some free cycles. If you change your mind and prefer not to include it, I'd be happy too and the issue can be closed.

javihernandez avatar Nov 09 '20 19:11 javihernandez