Committing a suggested change in github is not signed.

[rijobro]

If I create a PR and someone suggests a change which I approve and commit (all via the browser), the commit isn't signed off and then the DCO fails. Since we require all commits to have DCO, this therefore means that we can't use the suggested changes feature in github.

Is there any way around this?

[wyli]

it seems it's now supported by the github web UI to automatically sign https://docs.github.com/en/organizations/managing-organization-settings/managing-the-commit-signoff-policy-for-your-organization

[pafdad]

@wyli thank you for the link. It does however not at all talk about signing suggestions, which I believe is the issue stated by @rijobro. We are having the same issue unfortunately.

[wyli]

Hi @pafdad the doc provides more details https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/