dcmjs icon indicating copy to clipboard operation
dcmjs copied to clipboard

revert: Changes from streaming handler

Open wayfarer3130 opened this issue 1 week ago • 2 comments

There were issues found when running the streaming data parser, and using the async handling in JavaScript seems to produce an easier to understand version, so this change is being reverted in favour of the easier to understand version.

A limited number of changes are kept for things like constants and some jest logging configuration.

wayfarer3130 avatar Dec 15 '25 15:12 wayfarer3130

Deploy Preview for dcmjs2 ready!

Name Link
Latest commit a77f78244924845e863bbafd1061ca1003286ac3
Latest deploy log https://app.netlify.com/projects/dcmjs2/deploys/69402457e8e2bc0008db0e97
Deploy Preview https://deploy-preview-463--dcmjs2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Dec 15 '25 15:12 netlify[bot]

@pieper - this is a revert as discussed for the streaming parsing changes. I will let you know when there is a separate PR for adding a separate class instance for async based streaming parsing.

wayfarer3130 avatar Dec 15 '25 15:12 wayfarer3130

@pieper - I will merge this tomorrow if you don't have any feedback. It is basically just: git revert SHA1SUM on the streaming parser.

wayfarer3130 avatar Dec 16 '25 19:12 wayfarer3130

That sounds good to me, thanks.

pieper avatar Dec 16 '25 19:12 pieper