David Claux

Results 20 comments of David Claux

The templating engine should not return an object if it is fed with a template that has a top level array. It should produce an array. It should be the...

Also re: "if the given card payload is an array" - that is simply not possible: an Adaptive Card cannot be expressed as an array. It must be expressed as...

I'll try to fix this. Will replace `document.getElementById` with `querySelector` which works at the element level, that should do the trick.

I'm wondering if the logic in `shouldComponentUpdate` might mistakenly return `true` even when the new and old `hostConfig` and `payload` are the same.

@paulcam206 I considered doing that (in the JS SDK it's not difficult). The reason I didn't go for it is that an input might have an initial, valid value and...

@sschoeb the issue should now be fixed in Teams. Are you still able to repro in Teams web/desktop?

@shalinijoshi19 the person who opened this issue is explicitly referring to the `schema.ts` file that is part of the JS library. I've always wanted to remove it and was not...

@Lanakire since you guys have apparently done the work of updating the schema.ts file, would you be willing to contribute that to the repo?

@shalinijoshi19 `horizontalAlignment` _should_ be supported on ActionSet. It's easy enough to remove support in the designer for now, but we need to revisit why renderers other than JS do not...