Daniel C. Jones

Results 167 comments of Daniel C. Jones

The other potentially breaking change that's been brought up a few times is generalizing `RGB`, since sRGB is far from the only RGB colorspace, despite being the most common. I...

That's very interesting. So it's possible that it's not quite as bad as I thought. If that's the case, for the purpose of choosing colors I could use something like...

I guess there are two ways to frame the problem: 1. maximize distinguishability with constraints on pleasantness 2. maximize pleasantness with constraints on distinguishability (2) is what you're proposing, and...

I think the current colors are ok. The main problem is that `distinguishable_colors` become really finicky with color blindness simulation, which I think is more a problem with the simulation...

This (also documented in #6) occurs because assembler flags are incorrectly set here and in the line below it. https://github.com/ncbi/ncbi-vdb/blob/09046b4b477008287f9d093b25c770b39151132a/libs/krypto/Makefile#L138 A bunch of instruction sets are enabled for the compiler,...

Yes, absolutely. We're adding things as they get implemented in Bio.jl. It's taken a while to iron out our parsing system, but those will be included in the near future....

The solution I'm inclined towards is to use custom comparison functions within the package. That is, instead of defining `Base.isless(::AbstractInterval, ::AbstractInterval)`, define some other functions, say `interval_isless` and `interval_isequal` and...

I'm open to this. Is there a common interface for children of `AbstractIntervalTree` that you have in mind?

Sorry I missed your PRs. They're merged now. A problem with implementing a Set API is that the implementation here is not a set. It's perfectly valid to insert two...

If you're keeping a set of many string, then there's clearly an advantage to a hat-trie version that saves 4-8 bytes per entry by not keeping a value. Since the...