KeyValueObjectMapping icon indicating copy to clipboard operation
KeyValueObjectMapping copied to clipboard

Reviewed DateFormatter used for date conversion

Open rchampourlier opened this issue 11 years ago • 3 comments

Reviewed how the DateFormatter is created to follow Apple's guidelines and demo implementation provided in this documentation.

IMO, it makes more sense not to consider user locale since we generally are parsing dates from a backend API, not user entered data. If we don't do it this way, it seems the dates will be converted using local settings, such as non-Gregorian calendar, AM/PM preferences, etc.

rchampourlier avatar Apr 18 '13 10:04 rchampourlier

Could you add a property to configuration, so the user can switch between the locales? And if there's no locale use what you've done.

dchohfi avatar Jun 08 '13 16:06 dchohfi

Btw, nice add :)

dchohfi avatar Jun 08 '13 16:06 dchohfi

Wow, sorry, I completely forgot I hadn't even answered to your comment... I'll have to force myself to get some time to finish this so you can merge it...

Again, please excuse me for the delay and thanks for notifying me again!

rchampourlier avatar Sep 11 '13 06:09 rchampourlier