Issue#74: Improved performance by the factor of 10

[atlasgurus]

….b.c

The change is simple caching of the parse(), normalize() and strigify() functions

[atlasgurus]

Fixed issues, will reopen.

[katanacrimson]

What's the status of this, other than "in limbo"?

[atlasgurus]

I created a pool request. The implementation was working well and my customer (FireEye, Inc.) is already using it. Just need to merge it.

On Mon, Feb 5, 2018 at 6:22 AM, Damian Bushong [email protected] wrote:

What's the status of this, other than "in limbo"?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dchester/jsonpath/pull/75#issuecomment-363098495, or mute the thread https://github.com/notifications/unsubscribe-auth/ALcSNWHn6_DKXHeoVyJzfQfx-dXr-Gydks5tRw7DgaJpZM4PQkyt .

-- Vassili Gorshkov Atlas Consultants Group, Inc.

[katanacrimson]

Meant that more for the maintainers, because it's just been sitting here without comment. :)

[timo-klarshift]

Dear maintainer, is it possible to accept this pull-request ?

[PhilipJohnBasile]

Dear maintainer, can you PLEASE merge this :)

[dchester]

Thanks, I'll take a look here. There may be some trade-offs to consider around memory usage, and I'd rather not use memoize directly from underscore, since that makes the front-end build trickier. But let's see what we can do...

[PhilipJohnBasile]

Thank you :) Our team is waiting with our breaths held :)

[PhilipJohnBasile]

Can we exhale yet @dchester ?

[jlutzhbo]

@dchester any updates on this? Can we merge this in please?

[movitto]

We just pushed a similar commit to our fork (available on npm): https://github.com/DevNullProd/jsonpath-sandbox/commit/f62ddee33aee04c2177bdaa4938bd865183f461c

[movitto]

We pushed a follow on patch allowing the user to set a timeout to expire the cache. Thus the memoized values will not grow in memory indefinitely.

https://github.com/DevNullProd/jsonpath-sandbox/commit/dffaa749885e9b039e61d91230c9bc76c425bb75