epilogue icon indicating copy to clipboard operation
epilogue copied to clipboard

Fix check of restify vs express

Open ClementParis016 opened this issue 7 years ago • 1 comments

Restify's createServer method allows a name option to customize the server name.

If it's value is changed from "restify", the following check would think it's running under Express: https://github.com/dchester/epilogue/blob/d46def3dfc7b9dd7b25303b124bb337499cc9f1f/lib/Controllers/base.js#L73-L74

And then the server would crash because app.delete is not a function in Restify.

This PR takes a safer approach by simply checking if app.delete is undefined.

ClementParis016 avatar Oct 13 '17 16:10 ClementParis016

Hello, please consider contributing this change to finale, a sequelize 4.x fork of epilogue

tommybananas avatar Nov 10 '17 05:11 tommybananas