wefe icon indicating copy to clipboard operation
wefe copied to clipboard

Missing WEAT words

Open kato8966 opened this issue 1 year ago • 3 comments

There are two versions of unpleasant_5 words in the original WEAT paper. One of them is used in WEAT 1, and the other is used in WEAT 3. (For example, the former includes "prison," while the latter does not.) However, wefe/datasets/data/WEAT.json has only the former.

I fixed the problem by renaming unpleasant_5 to unpleasant_5a and adding unpleasant_5b (This is the fix branch. https://github.com/kato8966/wefe/tree/fix-weat-words), but this breaks backward compatibility.

Should I proceed and make a PR, or should I try a different approach?

kato8966 avatar Nov 15 '23 07:11 kato8966

Hi @kato8966 ,

Thanks for noticing it and trying to correct it! Yes, make a pull request to develop and we will evaluate it. Most likely we will have to change the experiments notebook.

pbadillatorrealba avatar Nov 20 '23 02:11 pbadillatorrealba

Sorry, but I'm currently busy and don't have enough time to fix all the problems caused by this compatibility-breaking change. What do you think I should do?

kato8966 avatar Nov 20 '23 07:11 kato8966

No problem :) Just upload the patch with the words and I will correct the compatibility issues later.

pbadillatorrealba avatar Nov 26 '23 20:11 pbadillatorrealba

Solved

felipebravom avatar Aug 12 '24 13:08 felipebravom