wefe icon indicating copy to clipboard operation
wefe copied to clipboard

Published 20 hours ago • verified publisher icon dccuchile

Feature/ran

Open mzambrano1 opened this issue 2 years ago • 1 comments

mzambrano1 avatar May 10 '22 17:05 mzambrano1

I have 2 more comments:

  • Wouldn't it be better to define the target function in the RAN class, as another method or even part of the forward?
  • The fit method is not compatible with the superclass. It is missing the debias_criterion_name parameter. It is probably also missing its functionality (give a name to the new embedding).

pbadillatorrealba avatar Jul 04 '22 00:07 pbadillatorrealba