dcbr
dcbr
I cannot modify this PR branch, so I cloned it to my own repository and rebased onto the latest development branch. You can see the result [here](https://github.com/dcbr/node-signpdf/tree/signer-external-rebase). All tests pass...
Regarding your last point, I'm not sure I fully understand what you mean. > I don't really like this approach as it's mixing the responsibilities of signature generation (the actual...
Ok, thanks for the further clarifications. This PR was my first attempt and idea of providing some extra functionality that is currently not supported, but I'm definitely open to reconsider...
This works fine for me (on Windows) when pressing the 'q' key instead of closing the window manually (using the mouse to click on the close button). I think there's...
I think this test should call `iren.process_events` until the `TimerEvent` is fired, similarly to what is done in [`test_timer`](https://github.com/pyvista/pyvista/blob/e6ebf94920a02a54e6c04bb583b9d4f98b3d88f1/tests/plotting/test_render_window_interactor.py#L149) (not sure why we have different methods to deal with `TimerEvent`...
Ready for review. The documentation build should succeed if it uses VTK 9.2. The reason why the coverage is so low is unclear to me at the moment. All of...
> @dcbr, the docs are failing from these changes The docs fail because they are using VTK 9.1.0 (and they need VTK 9.2.0 to showcase all chart features). I believe...
> I'm also tempted to run (or try to) the docs in Python 3.11 since it should be somewhat faster. I just installed Python 3.11.1 locally (Windows 10) and doc...
Ready for review. The remaining codecov complaints are all related to "compatibility code" for VTK
> Should we add no-cover pragmas? VTK < 9 is becoming pretty obscure. Definitely, I kind of forgot those existed. Added in last commit!