Dylan Baker

Results 372 comments of Dylan Baker

We also have some work toward being able to deal with the stdlib thing in CPS, although it's probably not sufficient in all cases, nor do I think any of...

I think I have some patches for this around somewhere from back in the days when this was still an unstable feature, let me have a look

Oh, this is interesting. I didn't have patches, but I did some poking, and our handling of Clang's PGO is completely broken as well, because it needs a different implementation...

I'm confused, I always run with just `pytest [args]` and never use the `run_unittests.py` wrapper. edit: We have the configuration in `setup.cfg` to make that work by default, and I...

Ah, yes. looking it at I did put that environment variable in my nix shell configuration. I guess that means all we need to do is actually ensure that the...

Yeah, I don't need any of that. `MESON_UNIT_TEST_BACKEND=ninja pytest -k test_bindgen_drops` is sufficient. Having the environment variable set for vscode is enough to get pytest working as well in the...

LGTM once they commits get squashed. Thanks!

I also feel obligated to point out that in at least some cases `get_transitive_link_deps` is subtly broken, see a couple of the commits in https://github.com/mesonbuild/meson/pull/12539/ to see what I mean

It also missing adding `self`, so if you have a dependency tree like: ``` A -> B -> C -> D ``` Then the transitive tree will be `{C, D}`,...