David Cavins
David Cavins
Here's the change I was suggesting: https://github.com/dcavins/buddypress-docs/commit/80690b4c6a2349cef310a021b63bc05e05650f22 The change is that if the group doesn't have the needed metadata, it should assume that Docs hasn't been activated for the group....
Ah, I'm a backslider. My change means that groups that have been getting by with no metadata would be left in the cold, which seems extreme. So, to make the...
I'm no longer proposing that we change `bp_docs_get_group_settings()`, but I would like to consider running the data clean-up routine (in the gist https://gist.github.com/dcavins/80c2c83e6b74295e9b10) on upgrade to 1.9, so that every...
I'm not exactly sure how we want to add an upgrade script. In the BP style?
That all seems reasonable, and I'll do it for 2.0.0. Or some later 1.9.x. It's definitely not a blocker.
This would be a good chance to update the css approach of the default bp-docs.css too, to minimize id selectors.
An easy way to see if another plugin is part of the issue is deactivating all of the plugins leaving only BP Docs and BP active, switching to the twentythirteen...
Some of the selectors have a nuclear-level amount of selector juice, so overriding them in a theme requires even more juice and results in themes having to write a lot...
I'd bet a dollar that there's a file in a plugin or theme somewhere that has a single white space before the opening `
Oh we definitely don't want to rewrite any more of the markup than we have to to preserve styling that people have sweated over. But, adding classes where appropriate would...