oauth2-cli icon indicating copy to clipboard operation
oauth2-cli copied to clipboard

Change Base64 for HEX encoding to survive URL encoding done by various API's

Open SaltwaterC opened this issue 6 years ago • 1 comments
trafficstars

Hi. Ran into the situation where a Base64 URL encoded state passed to an authorisation endpoint (e.g Netatmo's API) came back partly decoded i.e %2B came back as + - which is part of the standard Base64 charset. This is further decoded when comparing the initial state with the passed back state so + becomes (space, i.e %20, + is an alternative way to URL encode space) which then fails the comparison and oauth2-cli fails with an invalid state error.

This PR changes the Base64 encoding for HEX encoding which is better suited to survive across URL's passed back and forth and silly things done by some service API's. Since this is basically a random string, the encoding doesn't really matter than much for as long as it doesn't cause issues.

SaltwaterC avatar Jan 04 '19 18:01 SaltwaterC

I was only able to authenticate with restream.io after patching with the code in this PR. Thanks!

dsnopek avatar Jul 16 '21 20:07 dsnopek