transfermarkt-scraper icon indicating copy to clipboard operation
transfermarkt-scraper copied to clipboard

Contract Expiring

Open siddhanuka opened this issue 2 years ago • 1 comments

We can add the contract expiry date along with the player_valuation file, which will give another dimension of problem statement to be answered to the dataset. I propose this as an enhancement to extend the scraper.

image

siddhanuka avatar Oct 15 '22 07:10 siddhanuka

@siddhanuka, the contract expiration per player is already being scraped. Check this line https://github.com/dcaribou/transfermarkt-scraper/blob/25620ce7e746da012e6339885e57132c92a72771/tfmkt/spiders/players.py#L80 This represents the expiration date for the current contract of each players (i.e, if a player changes contract, this value would change too). If this works for you, I can have it published to the dataset (players file)

Screenshot 2022-10-15 at 17 08 04

dcaribou avatar Oct 15 '22 15:10 dcaribou