Danny Canter

Results 98 comments of Danny Canter

I think the Project Checks are failing because you're using github.com/pkg/errors in a spot here and it was removed as a direct dependency

PR description is great but please add some description to the commit message as well describing the need for this change and what it fixes

I think the reason was that PR had been stalled for awhile and wasn't sure if it'd be done in time for 1.7. Would it be undesirable to use the...

@mikebrow pingaroo on the above. Question: given we don't vendor an exact tag of the spec here today already, am I right in assuming we could re-vendor image-spec from the...

This would be pretty cool, can look into this. iirc there were some issues/bugs with uds on some newer versions of windows. Have to remember what the issue(s) were first..

@kzys Here's the original blog post for more info https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/

I'll need to rebase after this lands to fix the CI issues https://github.com/containerd/containerd/pull/7293

@BigVan I'd actually removed some work recently that passed annotations down to snapshotters as the containerd snapshotter label format wouldn't pass k8s annotations validation anyways. It would split an annotation...

Makes sense for the interacting with CRI without k8s use case, I'd actually removed it for that reason 😆. I thought if k8s couldn't make use of it it wouldn't...

> > I thought if k8s couldn't make use of it it wouldn't be worthwhile to keep > > @dcantah my understanding is that K8s could make use of it...