Daniel Abib

Results 47 comments of Daniel Abib

Hi @reedham-aws, Thank you for reviewing! Let me address your questions: ## 1. Issue Link Relevance You're absolutely right to question this - **I linked the wrong issue in my...

# PR #8297: Add .env file support for local Lambda invocations ## Which issue(s) does this change fix? Fixes #1355 **Note**: The PR description originally linked issue #2151 by mistake....

## Manual Testing Completed ✅ Tested dotenv functionality with 4 comprehensive scenarios - **All Passed**: ✅ Basic .env loading ✅ JSON override precedence (JSON > dotenv > template) ✅ Missing...

Hi @reedham-aws, Thanks for the additional review! I've addressed all 4 comments: ### 1. Function-Specific Overrides ✅ Great question! I've **implemented this feature** - .env files now support function-specific overrides...

> @dcabib I don't think you have pushed any commits adding support for function specific overrides. When you do that, it would also be helpful for future reviewers if this...

@reedham-aws I've implemented your suggested asterisk (*) separator fix! Replace underscore with asterisk separator for function-specific env vars Changed from underscore (_) with PascalCase detection to asterisk (*) separator for...

Hey @jrbarnard, I need to see this in action to track down what's happening. Can you share the CDK code that's creating these duplicate IDs? I'm particularly curious how you...

@Prachi-Philips Looks like this might be a duplicate of: - [#6114](https://github.com/aws/aws-sam-cli/issues/6114) - Bug: sam build - PermissionError - [#7968](https://github.com/aws/aws-sam-cli/issues/7968) - Bug: sam build - AttributeError - [#1491](https://github.com/aws/aws-sam-cli/issues/1491) - `sam local...

@jack-e-tabaska This looks like a classic race condition between CloudFormation creating the Lambda functions and the ECR repository permissions being set up. The fact that you're seeing the ECR permissions...

Hey @claudevandort! 👋 Great question, and yeah, I can totally see why you're confused - those two issues you referenced are kinda talking past each other. **TL;DR: In my point...