Daniel Widdis

[DISCUSS] How should we handle a successful deprovision with a failure in workflow state update

1

Coming from https://github.com/opensearch-project/flow-framework/pull/689#discussion_r1585173319 When deprovisioning, successfully deleting all resources gives a successful response to the user. There is a possibility of an unexpected failure resetting the state document to NOT_STARTED...

### Is your feature request related to a problem? Parsing of Workflow Nodes (steps) assumes that JSON objects are key-value maps unless specifically coded otherwise: https://github.com/opensearch-project/flow-framework/blob/51e229ca0a54a33fef1da42be704b070cc3072b4/src/main/java/org/opensearch/flowframework/model/WorkflowNode.java#L163-L180 This is brittle and...

[BUG] Updating a template unnecessarily checks for the existence of a template we'll overwrite

15

### What is the bug? When updating a template, we perform two get requests, one to check for the existence of the template (that we are going to overwrite), and...

### Is your feature request related to a problem? Making one change on a WorkflowState object requires re-adding all the individual fields through the builder. See for example: https://github.com/opensearch-project/flow-framework/blob/e3a878405848613ed0ed6166bec281bcbdb97346/src/main/java/org/opensearch/flowframework/transport/GetWorkflowStateResponse.java#L51-L55 ###...

### Is your feature request related to a problem? OpenSearch doesn't (yet) publish an arm64 build but they will soon. We reverted to macos-13 in #686 to keep building on...

### Is your feature request related to a problem? Our BWC tests are limited and essentially were the minimum required for the feature they were added with. We need to...

### Is your feature request related to a problem? Workflow Steps are tightly coupled to the APIs they implement. The APIs are hosted in external repositories, and there is not...

[REFACTOR] Eliminate duplication of required input / output List/Set

7

### Is your feature request related to a problem? The [WorkflowValidatorTests](https://github.com/opensearch-project/flow-framework/blob/main/src/test/java/org/opensearch/flowframework/model/WorkflowValidatorTests.java) class contains a lot of repetitive code that could be refactored to be more general. This test class was...

[REFACTOR] Move BWC tests to their own gradle build

1

Coming from https://github.com/opensearch-project/flow-framework/pull/551#discussion_r1516911231 ### Is your feature request related to a problem? The `build.gradle` file is getting big and confusing to navigate. ### What solution would you like? Change our...

The `CONTRIBUTING.md` file in this repository [specifies a longer license header](https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#license-headers). This conflicts with apparent (authoritative?) guidance posted in a comment on the `alerting` project repo here, although the qualification...