Daniel Widdis

Results 473 comments of Daniel Widdis

@dk2k this will be mergeable after you respond to the suggested change.

> I accepted the suggested change Well, apparently I shouldn't have suggested that. It's failing precommit and gradle check because of ForbiddenAPIs: ``` Forbidden method invocation: java.lang.Boolean#getBoolean(java.lang.String) [use org.opensearch.common.Booleans#parseBoolean(java.lang.String)] ```...

Sounds like a reasonable new feature. Feel free to contribute!

> As per [current documentation](https://docs.opensearch.org/docs/latest/automating-configurations/api/provision-workflow/#:~:text=wait_for_completion_timeout,execution%20continues%20asynchronously.), if wait_for_completion_timeout is exceeded for Provision API, execution continues asynchronously. ~To be clear, only existing in-progress steps (which have already been triggered) continue to completion....

To clear up any confusion: the `wait_for_completion_timeout` is primarily intended to avoid the need to poll for status, by just delaying the return from the REST call. Workflow failure from...

Revisiting this to update the feature request: - automatic deprovisioning under some conditions is probably a very useful feature - given wait_for_completion_timeout's design, it's likely not the best option. Its...

Hey @yizheliu-amazon I apologize for the slow response to this. Trying to address your comments here. > > Its main purpose is to avoid the need to poll > >...

> To streamline this process, we're implementing below features: > > 1. Auto-merge capability for version increment PRs > > * We will be enabling [auto-merge feature](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request) for version increment...

Attempted to reproduce this with a local cluster and it works fine; something must be different on AOS with this. Also, nothing in Flow Framework would produce a 502 error....