David Buezas

Results 344 comments of David Buezas

Why does not using GPIOR0 save space? Being a IO register, I think guarantees the compiler doesn't remove the code (b/c it is volatile). It may be a way to...

Oh, that makes sense now. If it's put in a variable, the compiler just keeps that at hand in a CPU register. GPIO0R is not a cpu register so extra...

Nice! another 24 bytes down! BTW, did you give the timer setup code a look? (the one in the first post in the issue)

> It will be a lot of work to prepare an addition menu for the EEPROM's size selection. The menu side is not that bad, I made that for the...

If you give me a constant name and values for each EEPROM size I can add the menu side. Code wise it is just a bunch of if macros

Ok, I'm assuming that ot os enough to add variants to the boards.txt that change: * upload.maximum_data_size=xxx (currently only 2048) * upload.maximum_size=xxx (currently only 29696) Plus something inside main.cpp so...

Great! Should we get rid of all those `#if defined` ? we're only supporting the 328p variant, right?

You ran out of flash space, maybe some library was updated and it is bulkier? By the way, 2 kb of flash are reserved for eeprom, so you could claim...

The link I posted is to a specific comment, there's what you need to do (basically upload via ISP and ignore warning. Or modify the available flash in boards.txt if...

This PR may be relevant in this discussion: https://github.com/dbuezas/lgt8fx/pull/261 Particularly because it may be incompatible with the ideas discussed in this issue.