ptime icon indicating copy to clipboard operation
ptime copied to clipboard

feat: add to_rfc1123 function

Open rbjorklin opened this issue 5 years ago • 1 comments

Hi @dbuenzli!

I've made an attempt at adding a string formatting function for RFC1123 which might solve #7 but please do go easy on me as this is my first attempt at contributing OCaml :sweat_smile:

I have been unable to test my function as the build script initially failed with ./build: line 39: syntax error near unexpected token ;;' and once I had removed OA, which I assume is a typo, I'm now met with:

❯ ./build
Solver failed:
  Ocamlbuild knows of no rules that apply to a target named src/ptime_top.mly. This can happen if you ask Ocamlbuild to build a target with the wrong extension (e.g. .opt instead of .native) or if the source files live in directories that have not been specified as include directories.
Backtrace:
  - Failed to build the target ptime_top.cma
      - Failed to build all of these:
          - Building src/ptime_top.cma:
              - Failed to build all of these:
                  - Building src/ptime_top.cmo:
                      - Failed to build all of these:
                          - Building src/ptime_top.ml:
                              - Failed to build all of these:
                                  - Building src/ptime_top.mly
                                  - Building src/ptime_top.mll
                          - Building src/ptime_top.mli:
                              - Building src/ptime_top.mly
                          - Building src/ptime_top.mlpack
                          - Building src/ptime_top.mli:
                              - Building src/ptime_top.mly
                  - Building src/ptime_top.mllib
          - Building ptime_top.cma:
              - Failed to build all of these:
                  - Building ptime_top.cmo:
                      - Failed to build all of these:
                          - Building ptime_top.ml:
                              - Failed to build all of these:
                                  - Building ptime_top.mly
                                  - Building ptime_top.mll
                          - Building ptime_top.mli:
                              - Building ptime_top.mly
                          - Building ptime_top.mlpack
                          - Building ptime_top.mli:
                              - Building ptime_top.mly
                  - Building ptime_top.mllib

Any idea what's going on here?

EDIT: The motivation for this is that I'm trying to add a test suite for webmachine to the Tech Empower Benchmark suite and I'm being met by:

WARN for http://tfb-server:8080/plaintext
     Invalid Date header, found "2020-09-19T23:42:19-00:00", did not match "%a, %d %b %Y %H:%M:%S %Z".
     See https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#specific-test-requirements

rbjorklin avatar Sep 20 '20 01:09 rbjorklin

I won't have the time to look into this before two weeks. Ping me back if I forget.

dbuenzli avatar Sep 22 '20 11:09 dbuenzli