down icon indicating copy to clipboard operation
down copied to clipboard

`%%LIBDIR%%` in `down.top` needs to be escaped

Open nojb opened this issue 1 year ago • 1 comments

This is because on Windows it is common for %%LIBDIR%% in

https://github.com/dbuenzli/down/blob/e3a4f38e02bf75fd0206d97dc74c6a5c26342023/src/down.top#L9

to contain backslashes, which need to be escaped (eg by using String.escaped) in

https://github.com/dbuenzli/down/blob/e3a4f38e02bf75fd0206d97dc74c6a5c26342023/pkg/pkg.ml#L20

nojb avatar Jun 11 '24 22:06 nojb

~~Isn't it rather the #directory directive implementation which should escape ?~~

Forget about that.

dbuenzli avatar Jun 11 '24 22:06 dbuenzli

@MisterDA can you please try with opam pin topkg --dev to confirm that @nojb's suggestion fixes the problem.

Not sure why this got stuck for so long.

dbuenzli avatar Jan 15 '25 14:01 dbuenzli

Can confirm that it works!

MisterDA avatar Jan 15 '25 14:01 MisterDA

Thanks!

dbuenzli avatar Jan 15 '25 14:01 dbuenzli