cmdliner icon indicating copy to clipboard operation
cmdliner copied to clipboard

Fix missing module implementation for Cmdliner_term_deprecated

Open bcc32 opened this issue 4 years ago • 2 comments

Just a simple fix for a missing module implementation error that I discovered while trying to update the version of cmdliner used in nixpkgs. Here's the error I get when trying to build uuidm, for example:

ocamlfind ocamlopt -linkpkg -g -package cmdliner -package bytes -I src -I test src/uuidm.cmx test/uuidtrip.cmx -o test/uuidtrip.native
+ ocamlfind ocamlopt -linkpkg -g -package cmdliner -package bytes -I src -I test src/uuidm.cmx test/uuidtrip.cmx -o test/uuidtrip.native
File "_none_", line 1:
Error: No implementations provided for the following modules:
         Cmdliner_term_deprecated referenced from /nix/store/hd5n49fvwmhbxh9jyq9gjsj6d0qqhghm-ocaml4.13.1-cmdliner-1.1.1/lib/ocaml/4.13.1/site-lib/cmdliner/cmdliner.cmxa(Cmdliner)
Command exited with code 2.
pkg.ml: [ERROR] cmd ['ocamlbuild' '-use-ocamlfind' '-classic-display' '-j' '4' '-tag' 'debug'
     '-build-dir' '_build' 'opam' 'pkg/META' 'CHANGES.md' 'LICENSE.md'
     'README.md' 'src/uuidm.a' 'src/uuidm.cmxs' 'src/uuidm.cmxa'
     'src/uuidm.cma' 'src/uuidm.cmx' 'src/uuidm.cmi' 'src/uuidm.mli'
     'test/uuidtrip.native']: exited with 10

bcc32 avatar Mar 28 '22 21:03 bcc32

Thanks!

However, is there any reason why you are not using theMakefile build ? That's the official build procedure (see the opam file).

The topkg build will be removed at some point.

dbuenzli avatar Mar 28 '22 21:03 dbuenzli

Hmm, I'm not the maintainer of the nixpkgs package for cmdliner, but I don't think there would be any objection to updating to the new build procedure. It's probably just out of date. Feel free to merge or close at your preference---it looks like there is no error when using the Makefile.

bcc32 avatar Mar 28 '22 22:03 bcc32

Thanks!

dbuenzli avatar Dec 15 '22 11:12 dbuenzli