Daniel Buch Hansen

Results 18 comments of Daniel Buch Hansen

I make some progress today and caught a [Backtrace](https://github.com/nushell/nushell/files/9993023/dev.rust.nushell.virtualenv.txt) locally. With some local changes to [virtualenv](https://github.com/pypa/virtualenv/blob/main/tests/unit/activation/test_nushell.py). Next step will be to look for some additional context around the panic around...

@fdncred I can confirm I cannot reproduce a crash. Also I think #6269 is potential fixed aswell, by a rough analysis of the attached stack dump. Feel free to close...

> Yippie! Everything going green! Great work @dbuch. I think we need a few reviewer looks if the fixes are straightforward or hiding a larger problem but then we are...

> On macOS, `custom_window_frame` is already resizable on `master`. Cool, wonder if it works out-of-box on (Legacy) X11 compositor. > I assume adding `.with_resizable(true)` to the `ViewportBuilder` is not enough...

Right, I can confirm this problem. > Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)? Fira Code Nerd Font and Fira Code Nerd Font Mono Same here....

Basically is think the setting for the console height would be better to have a percentage slide toggle instead of the pixels? And then as a extra checkbox 'fullscreen' -...

I agree with katastrophal. That widget with 10 or 5 percent steps would be great.

Exactly, the percent-based height solves the different resolution plus it seems more user-friendly indeed. true win/win - perfekt.