David Buchmann

Results 944 comments of David Buchmann

so would we have to listen for migration events and run the extra sql each time a migration happens? (or query the database to decide if we have to run...

we are discussing an event in orm here: https://github.com/doctrine/orm/pull/11409

the issue is still relevant. the solution unfortunately did not progress yet.

> I think you could retarget to 2.x i was wondering. happy to do that. would that be the 2.21.x branch? i do not see a 2.x branch.

does the CI provide a preview somewhere so i can check if anything is rendered incorrectly?

> 2.20.x i changed the branch and target of this merge request.

afaik it would be ready to merge. @greg0ire is there anything you need me to adjust or is it fine like this?

i suspect the problem is the missing blank line: https://github.com/doctrine/orm/pull/11951 is there a way to preview the render before merging?

the idea is that if you set a custom-ttl, this would be respected by the cache regardless of s-maxage / max-age. the CustomTtlListener you linked temporarily [replaces](https://github.com/FriendsOfSymfony/FOSHttpCache/blob/2b2ccae740c164c55ea43c6ccf5fca3011d00537/src/SymfonyCache/CustomTtlListener.php#L63) s-maxage with the...

uh. maybe that changed since when we implemented the event dispatching http cache - or we never noticed that issue. i do think the intention was to allow the listener...