David Buchmann

Results 944 comments of David Buchmann

afaik there is no testing with Symfony 4. there is #203 which tries to fix another issue in Symfony 4. this error sounds like a change in symfony, can you...

maybe the tests are lacking. are you sure you do not access this services with a $container->get() yourself? if its in this bundle, we should fix it to DI instead.

ups. can you try to rewrite that to inject the services and parameters in the constructor, instead of pulling them from the container?

hm, not sure if that is possible. if something relies on the work the routing did, things would fail miserably. but it actually could be that it can indeed work....

could also be offset after last result. lets remove the fixme and just have a comment that there are no results and no error. Am 24.04.2017 4:01 nachm. schrieb "Ben...

i would also change the version alias of the master branch before merging: https://github.com/liip/LiipSearchBundle/blob/581bd134a5b77662a93c9e665f75dccd345e67b5/composer.json#L32 to release i go to the project start page, there is a "releases" section. there you...

hi @benglass @lsmith77 and i are currently archiving inactive repositories in the liip organization. this made me stumble over this one. i suggest the following: you take this branch to...

I will archive this repository and abandon it on packagist. If you release a Bing bundle, please tell me and i will link to it.

there is no native support for this in the bundle currently, but it would of course be cool. we could provide a second action for autocomplete and document some js...

we could use this: https://developers.google.com/custom-search/docs/element