Fix concat macro when fields list is of length 1.

[jlkravitz]

This pull request fixes the issue described here.

Should this macro handle the case where fields|length == 0, or is that case handled upstream?

[ericmuijsvanoord]

Option: you could also do: CONCAT('', field_list)

[jlkravitz]

Option: you could also do: CONCAT('', field_list)

I like that @ericmuijsvanoord – updated the PR!

[jlkravitz]

Hi @ericmuijsvanoord whats the process for getting this merged?

[ericmuijsvanoord]

See this pull request: https://github.com/dbt-msft/dbt-sqlserver/pull/461 You need to attach a maintainer which can trigger the tests. However, in the current state, it is best to wait until the pull request 461 is passed. This fully revamps the adapter, based of dbt-fabric.

[astocks]

@jlkravitz any movement here? This is still causing issues with dbt-utils as you outlined in the OP.

[jlkravitz]

Nothing that I have heard!

Sent from iPhone

On Tue, Apr 23, 2024 at 3:37 PM Adam Stocks @.***> wrote:

@jlkravitz https://github.com/jlkravitz any movement here? This is still causing issues with dbt-utils as you outlined in the OP.

— Reply to this email directly, view it on GitHub https://github.com/dbt-msft/dbt-sqlserver/pull/447#issuecomment-2073283968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWWZK6O52XRBC2243DOVCTY62Z7VAVCNFSM6AAAAAA4TRO3TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTGI4DGOJWHA . You are receiving this because you were mentioned.Message ID: @.***>

[ericmuijsvanoord]

I don't think I can help with this, but there are conflicts that have to be resolved first (GitHub message).

[astocks]

I don't think I can help with this, but there are conflicts that have to be resolved first (GitHub message).

I can try to pick this up and get the tests to pass. Should I open a new PR? @ericmuijsvanoord

[ericmuijsvanoord]

@astocks : im not a maintainer I think. I'm not able to start the tests. Reach out to one of the maintainers.