dbt-sqlserver icon indicating copy to clipboard operation
dbt-sqlserver copied to clipboard

Published 20 hours ago • verified publisher icon dbt-msft

upgrade to support dbt-core v1.5.0

Open dataders opened this issue 1 year ago • 9 comments

Background

The latest version of dbt Core,dbt-core==1.5.0rc1, was published on April 13, 2023 (PyPI | Github).

How to upgrade

https://github.com/dbt-labs/dbt-core/discussions/7213 is an open discussion with more detailed information. If you have questions, please put them there!

The above linked guide has more information, but below is a high-level checklist of work that would enable a successful 1.5.0 release of your adapter.

  • [x] Add support Python 3.11 (if you haven't already)
  • [ ] Add support for relevant tests (there's a lot of new ones!)
  • [ ] Add support model contracts
  • [x] ~~Add support for materialized views~~ (this likely will be bumped to 1.6.0)

the next minor release: 1.6.0

FYI, dbt-core==1.6.0 is expected to be released at the end of July, with a release cut at least two weeks prior.

dataders avatar Apr 19 '23 15:04 dataders

we should look at #289 now that there is a test for it

sdebruyn avatar May 17 '23 11:05 sdebruyn

I've one question...

With support to dbt 1.5.x, will be possible to create constraints at table / incremental materializations?

romiof avatar May 22 '23 12:05 romiof

@romiof Yes, that should be part of it

sdebruyn avatar May 22 '23 13:05 sdebruyn

Any idea when dbt-sqlserver will support 1.5 ?

virgilp avatar Jun 29 '23 13:06 virgilp

The following error is also blocking using dbt 1.5.2 and dbt-sqlserver.

ImportError: cannot import name '_make_ref_key_msg' from 'dbt.adapters.cache' (/usr/local/lib/python3.11/site-packages/dbt/adapters/cache.py)

Edit: Add a link to the relevant dbt-core commit.

alison985 avatar Jul 18 '23 04:07 alison985

@virgilp

Any idea when dbt-sqlserver will support 1.5 ?

#441 should shed some light on the update

sdebruyn avatar Aug 22 '23 18:08 sdebruyn

Bumping, would be great to at least have some clue when it might be coming, since it seems it's pending some major refactoring effort?

If it's going to take another few months, someone in the community might want to pick up and complete https://github.com/dbt-msft/dbt-sqlserver/pull/390 as I think 1.5 has a bunch of new useful features.

trymzet avatar Sep 21 '23 18:09 trymzet

Any news on this? We (the AutomateDV dbt package) support SQLServer and are currently unable to upgrade from 1.4, 1.5, 1.6 & 1.7 as we wanted to wait for all adapters to support these new versions. If this isn't releasing any time soon we will need to release without up-to-date support for SQLServer. I understand this is community supported and it takes time - just want to know either way

DVAlexHiggs avatar Oct 18 '23 12:10 DVAlexHiggs

For anyone still looking, it looks like 1.7 will be implemented soon, see #461

trymzet avatar Jan 24 '24 14:01 trymzet