metricflow icon indicating copy to clipboard operation
metricflow copied to clipboard

[SL-1834] [Feature] Add new fields to dbt-jsonschema

Open Jstein77 opened this issue 11 months ago • 0 comments

Is this your first time submitting a feature request?

  • [X] I have read the expectations for open source contributors
  • [X] I have searched the existing issues, and I could not find an existing issue for this feature
  • [X] I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We need to update the dbt-jsonschema with new fields added to the spec. A community member flagged the following issues:

Hi Team, Does the dbt YAML validator json at https://github.com/dbt-labs/dbt-jsonschema need to be updated for the latest? I'm looking at github.com/dbt-labs/jaffle-sl-template and see things not described in any of the validator schemas. Examples:

  • File models/marts/customer360/orders.yml contains metric orders_fill_nulls_with_zero with type_params including fill_nulls_with and join_to_timespine not found in validation schemas
  • File models/marts/customer360/orders.yml contains metric twice_orders_fill_nulls_with_0 with type_params > metrics as a string. In the validation schemas it is an object with properties
  • File models/marts/ecommerce/olist_closed_deals.yaml contains metric mql_to_seller_conversion_rate_7_day_window_with_filter with conversion_type_params not found in validation schemas
  • File models/marts/ecommerce/olist_closed_deals.yaml contains metric mql_to_seller_conversion_rate_base with type: conversion which is not an expected enum value for type
  • File models/marts/customer360/order_items.yml contains saved_queries not found in validation schemas

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-1834

Jstein77 avatar Mar 11 '24 17:03 Jstein77