dbt-utils icon indicating copy to clipboard operation
dbt-utils copied to clipboard
verified publisher icon dbt-labs

update tests: -> data_tests: in README.md

Open syou6162 opened this issue 1 year ago • 3 comments

resolves https://github.com/dbt-labs/dbt-utils/issues/894

Problem

  • The README was not fixed at https://github.com/dbt-labs/dbt-utils/pull/893.

Solution

  • I updated tests: -> data_tests: in README.md

Checklist

  • [x] This code is associated with an issue which has been triaged and accepted for development.
  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] I have updated the README.md (if applicable)

syou6162 avatar Sep 02 '24 07:09 syou6162

@dbeatty10 Could you review this pull request?

syou6162 avatar Sep 05 '24 14:09 syou6162

@dbeatty10 Thank you for your response. I have corrected data-tests: to data_tests:.

According to the official documentation, tests: will continue to be supported, but dbt 1.8 and later will output a warning by default. I think that the number of users of dbt 1.8 and later will continue to increase, and versions prior to dbt 1.8 will reach the end of life support level on Nov 1, 2024. I think that dbt-labs would like to recommend data_tests:, and I think that data_tests: is appropriate as the documentation provided by dbt-labs.

syou6162 avatar Sep 05 '24 17:09 syou6162

@dbeatty10 Thank you for your response. I have corrected data-tests: to data_tests:.

According to the official documentation, tests: will continue to be supported, but dbt 1.8 and later will output a warning by default.

Is avoiding the warning your primary concern here? Or alignment with the official documentation? It's okay if your main concern is both or something completely else too!

If it's the warning, we do have an open issue to cease raising a warning here: https://github.com/dbt-labs/dbt-core/issues/10564. We'd probably update the official documentation at the same time.

dbeatty10 avatar Sep 05 '24 19:09 dbeatty10

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] avatar Mar 05 '25 02:03 github-actions[bot]

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

github-actions[bot] avatar Mar 13 '25 02:03 github-actions[bot]