dbt-spark icon indicating copy to clipboard operation
dbt-spark copied to clipboard

fix: update to use pyhive function to get compatible sasl

Open ntnhaatj opened this issue 5 months ago • 4 comments

resolves #1094 docs dbt-labs/docs.getdbt.com/#

Problem

Current SASL factory for TSaslClientTransport using SASLClient from pure-sasl which is incompatible with pyhive

Solution

Pyhive provides a wrapper PureSASLClient which implement some missing methods to interact with thrift-sasl.

This MR update to use get_installed_sasl of pyhive to decide which sasl client should be use in current environment.

Checklist

  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

ntnhaatj avatar Aug 31 '24 09:08 ntnhaatj