dbt-spark icon indicating copy to clipboard operation
dbt-spark copied to clipboard

Move to `pre-commit` only

Open mikealfare opened this issue 9 months ago • 0 comments

Problem

Our linters and typechecking tools create a lot of dependabot PRs. This is aggravated by the fact that we keep one set of reqs in dev-requirements.txt and another in .pre-commit-config.yaml.

Solution

  • move all reqs and config for linters and typecheckers into .pre-commit-config.yaml
  • run pre-commit autoupdate
  • run pre-commit run --all-files
  • fix resulting error from running pre-commit
  • remove make recipes that are no longer relative or are duplicative

Out of scope:

  • as a follow up, create a weekly action that runs pre-commit autoupdate against a temp branch, runs linting and typechecking, and merges on success or creates a PR on failure

Checklist

  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

mikealfare avatar Apr 26 '24 02:04 mikealfare