dbt-snowflake icon indicating copy to clipboard operation
dbt-snowflake copied to clipboard

implements pagination

Open matt-winkler opened this issue 1 year ago • 4 comments

resolves #810

Problem

Currently, dbt snowflake requests ALL schemas in a target database via the show terse objects command. This can create a bottleneck for some networks when the return payload forces snowflake to return data via internal stages.

Solution

This PR includes functionality that paginates the requests to list schemas in the target db.

The solution is similar to that within https://github.com/dbt-labs/dbt-snowflake/pull/572, but for paginating the listing of schemas instead of paginating the listing of relations.

NOTE: what performance concerns do we have with this?

Checklist

  • [X] I have read the contributing guide and understand what's expected of me
  • [X] I have run this code in development and it appears to resolve the stated issue
  • [X] This PR includes tests, or tests are not required/relevant for this PR
  • [X] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

matt-winkler avatar Oct 18 '23 22:10 matt-winkler

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: matt-winkler. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Oct 18 '23 22:10 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: matt-winkler. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Oct 19 '23 14:10 cla-bot[bot]

@mikealfare Thanks for the review on this. Haven't forgotten about it but tied up with quarter review items but plan to pick up again soon.

matt-winkler avatar Nov 06 '23 20:11 matt-winkler

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] avatar May 05 '24 01:05 github-actions[bot]

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

github-actions[bot] avatar May 12 '24 01:05 github-actions[bot]

@matt-winkler we can re-open this any time you want.

dbeatty10 avatar May 13 '24 12:05 dbeatty10