dbt-redshift icon indicating copy to clipboard operation
dbt-redshift copied to clipboard
verified publisher icon dbt-labs

Full redshift connector parameter support

Open christopherscholz opened this issue 2 years ago • 4 comments

resolves #332 docs dbt-labs/docs.getdbt.com/# alternative for #323

Problem

Currently not all connection methods, which the redshift_connector supports are currently possible with dbt-redshift. Also the connections.py does not fully reflect the move to redshift_connector yet. In the past the connection methods were handled by dbt-redshift itself, by parsing different credentials sets based on the connections method. With redshift_connector this should now be done by redshift_connector.

Solution

I have added all connection parameters from redshift_connector and removed the ConnectionFactory, as all connection methods are handled by redshift_connector now.

Many unit tests are now obsolete, as testing the different connection methods are now out of scope for dbt-redshift, but part of redshift_connector.

All the changes should be backwards compatible.

Checklist

  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX Lots new adapter credentials options

christopherscholz avatar Jul 30 '23 16:07 christopherscholz

Both unit and integration tests are successful for me. Unfortunately I cannot tests all the different connection methods (as I don't have those set up currently), but as this is part of redshift_connector anyway; I guess this out of scope.

christopherscholz avatar Jul 30 '23 16:07 christopherscholz

This is great. Currently we need to set client_protocol_version to 0 due to this Teleport limitation and looking forward to see this PR merged.

halilduygulu avatar Jul 31 '23 13:07 halilduygulu

Any updates here or what is currently blocking?

misteliy avatar Oct 14 '23 23:10 misteliy

+1 to @misteliy . Why are you not merging this pr?

halilduygulu avatar Nov 20 '23 14:11 halilduygulu

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] avatar May 19 '24 01:05 github-actions[bot]

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

github-actions[bot] avatar May 26 '24 01:05 github-actions[bot]

Could you please reopen as it was not resolved

misteliy avatar May 26 '24 07:05 misteliy