dbt-project-evaluator icon indicating copy to clipboard operation
dbt-project-evaluator copied to clipboard

Published 20 hours ago • verified publisher icon dbt-labs

Detect hyphen in hard coded reference

Open simmartynas opened this issue 2 months ago • 0 comments

This is a:

  • [ ] bug fix PR with no breaking changes
  • [x] new functionality

Link to Issue

https://github.com/dbt-labs/dbt-project-evaluator/issues/417

Description & motivation

In BigQuery, table references can contain - in them. Test find_all_hard_coded_references.sql does not detect this because regex (\w+) does not include the hyphen (-) character.

Integration Test Screenshot

Checklist

  • [ ] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • [x] BigQuery
    • [ ] Postgres
    • [ ] Redshift
    • [ ] Snowflake
    • [ ] Databricks
    • [ ] DuckDB
    • [ ] Trino/Starburst
  • [ ] I have updated the README.md (if applicable)
  • [ ] I have added tests & descriptions to my models (and macros if applicable)

simmartynas avatar May 03 '24 08:05 simmartynas