dbt-project-evaluator icon indicating copy to clipboard operation
dbt-project-evaluator copied to clipboard

Comments are incorrectly flagged as hard coded references

Open deanmorin opened this issue 6 months ago • 3 comments

Describe the bug

In some cases comments get flagged as hard coded references.

Steps to reproduce

In a comment, if a quoted string follows from or join it will be flagged as a hard coded reference.

-- from "a comment"
-- join "another comment"
-- from my_model
select
  1
from 
  {{ ref('my_model') }}

The first two comment lines (with the quoted strings) get flagged, the third line does not.

Expected results

No hard coded references found.

Actual results

Both "a comment" and "another comment" get flagged as hard coded references.

Screenshots and log output

System information

The contents of your packages.yml file:

Which database are you using dbt with?

  • [ ] postgres
  • [ ] redshift
  • [ ] bigquery
  • [x] snowflake
  • [ ] trino/starburst
  • [ ] other (specify: ____________)

The output of dbt --version:

Core:
  - installed: 1.7.3
  - latest:    1.7.4 - Update available!

  Your version of dbt-core is out of date!
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Plugins:
  - snowflake: 1.7.1 - Up to date!

Additional context

Are you interested in contributing the fix?

Unfortunately I do not have time.

deanmorin avatar Jan 02 '24 17:01 deanmorin