dbt-jsonschema icon indicating copy to clipboard operation
dbt-jsonschema copied to clipboard

recommended config links to outdated schema files

Open gofford opened this issue 10 months ago • 1 comments

Using the jsonschema config from the README I noticed that some valid yaml config was being flagged as an error. Looking into it it seems that the config in the README is linking to outdated schema files.

The stated config is equivalent to sourcing https://github.com/dbt-labs/dbt-jsonschema/blob/main/schemas/dbt_project.json which hasn't been updated in 4 months. In contrast the versioned schema files (https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas/latest) were updated 4 days ago -- these changes aren't being reflected, hence my error.

If I update the yaml.schemas config to use the latest files my "error" goes away.

Two ways of solving this:

  • update the recommended config in the README to use the files in https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas/latest, or
  • mirror the https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas/latest files at the https://github.com/dbt-labs/dbt-jsonschema/tree/main/schemas path and keep the README as-is.

I'm happy to PR this - which one do you prefer?

gofford avatar Apr 12 '24 13:04 gofford

@gofford i think the first option sounds right to me! the schemas currently in noted in the README are mostly there for backwards compatibility, and won't get updates, so we should point folks to the latest ones. Thanks for the callout!

dave-connors-3 avatar Apr 12 '24 14:04 dave-connors-3