dbt-core icon indicating copy to clipboard operation
dbt-core copied to clipboard

Fire skipped events at debug level

Open scottgigante opened this issue 2 years ago • 3 comments

resolves #8774

Problem

If fail_fast, dbt prints hundreds of lines "Skipping due to fail_fast", hiding the actual cause of the error deep in bash history (sometimes too deep to read)

Solution

This moves the "Skipping due to fail_fast" to log level DEBUG. An alternative would be to a) drop it altogether or b) aggregate the results together to a "Skipping tasks due to fail_fast". This approach requires the least modification to the task results framework.

Checklist

  • [X] I have read the contributing guide and understand what's expected of me
  • [X] I have run this code in development and it appears to resolve the stated issue
  • [X] Tests are not required/relevant for this PR
  • [ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • [X] This PR includes type annotations for new and modified functions

scottgigante avatar Jan 13 '24 07:01 scottgigante

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @scottgigante

cla-bot[bot] avatar Jan 13 '24 07:01 cla-bot[bot]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

github-actions[bot] avatar Jan 13 '24 07:01 github-actions[bot]

Can someone please approve workflows and review this?

scottgigante avatar Feb 29 '24 20:02 scottgigante

I'm going to close this in favor of https://github.com/dbt-labs/dbt-core/pull/10244

graciegoheen avatar Jun 07 '24 15:06 graciegoheen