dbt-core icon indicating copy to clipboard operation
dbt-core copied to clipboard

Fix package-lock file's bad indentation

Open jx2lee opened this issue 1 year ago • 1 comments

resolves #9319

Problem

when dbt deps created package-lock file, yaml.safe_load didn't include indents.

packages:
- package: dbt-labs/dbt_utils
  version: 1.0.0
- package: calogica/dbt_date
  version: 0.8.1
sha1_hash: f2bef868041b4f03296151f8be2969fc320a781a

Solution

solve bad indentation using yaml.load (set Dumper dbtPackageDumper)

packages:
  - package: dbt-labs/dbt_utils
    version: 1.0.0
  - package: calogica/dbt_date
    version: 0.8.1
sha1_hash: f2bef868041b4f03296151f8be2969fc320a781a

Checklist

  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • [x] This PR includes type annotations for new and modified functions

jx2lee avatar Jan 05 '24 15:01 jx2lee

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.13%. Comparing base (11cc71b) to head (5cfb1ea). Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9341      +/-   ##
==========================================
+ Coverage   86.64%   88.13%   +1.48%     
==========================================
  Files         224      178      -46     
  Lines       27004    22480    -4524     
==========================================
- Hits        23398    19812    -3586     
+ Misses       3606     2668     -938     
Flag Coverage Δ
integration 85.51% <100.00%> (+1.92%) :arrow_up:
unit 62.74% <0.00%> (-2.48%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 05 '24 16:01 codecov[bot]

@gshank Could you please let me know when you might be able to review it? Thank you in advance for your time and consideration.

jx2lee avatar Mar 17 '24 05:03 jx2lee