dbt-core icon indicating copy to clipboard operation
dbt-core copied to clipboard

[CT-1074] [Feature] Ability to change background color of graph area and node edges (lines)

Open noel opened this issue 2 years ago • 9 comments

Is this your first time submitting a feature request?

  • [X] I have read the expectations for open source contributors
  • [X] I have searched the existing issues, and I could not find an existing issue for this feature
  • [X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Now that dbt 1.3 will allow us to change node colors, I thought it would be nice if we could also change the background color of the lineage area.

Describe alternatives you've considered

No response

Who will this benefit?

users of dbt docs.

Are you interested in contributing this feature?

No response

Anything else?

https://getdbt.slack.com/archives/CKHBDNHA6/p1661355317116189

noel avatar Aug 24 '22 22:08 noel

Note: This will require changes across this repo for setting configs and https://github.com/dbt-labs/dbt-docs for rendering the colors.

sungchun12 avatar Aug 24 '22 22:08 sungchun12

agreed this would be cool! it's not something the Core team is likely to prioritize for the foreseeable future, so moving out of triage and into the "help wanted" and "good first issue" ice bucket

lostmygithubaccount avatar Aug 26 '22 19:08 lostmygithubaccount

I would be interested in working on this but I would only be able to get started on it in about a month

korompaiistvan avatar Sep 01 '22 09:09 korompaiistvan

Hi! Is anybody working on this ?

alzaar avatar May 19 '23 19:05 alzaar

This is not something that we are likely to prioritize anytime soon, and I'm going to remove the good_first_issue and help_wanted labels in the meantime.


Sorry for any churn here @alzaar! Please let me know if you're looking for a good_first_issue, but having trouble finding one. Another place to look would be in the repos for the adapters. Some lists of "good first issues" without pull requests here:

dbeatty10 avatar May 20 '23 00:05 dbeatty10

Thanks @dbeatty10 for keeping me in the loop. Would it be possible if I have a look at #5301 ? Looks like a straightforward change for making initial changes within the repo.

alzaar avatar May 22 '23 01:05 alzaar

@alzaar I just left a comment here to double-check if that issue is still relevant or not.

dbeatty10 avatar May 22 '23 15:05 dbeatty10

Does anyone know any workarounds for this? Some script that runs between dbt docs generate and dbt docs serve and just finds-replaces color codes?

fran-at-dribia avatar Aug 23 '23 06:08 fran-at-dribia

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

github-actions[bot] avatar Feb 23 '24 01:02 github-actions[bot]