dbt-core
dbt-core copied to clipboard
Andy/fix init comment
resolves https://github.com/dbt-labs/dbt-core/issues/5791
Description
Checklist
- [x] I have read the contributing guide and understand what's expected of me
- [x] I have signed the CLA
- [x] I have run this code in development and it appears to resolve the stated issue
- [x] This PR includes tests, or tests are not required/relevant for this PR
- [x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
- [x] I have run
changie new
to create a changelog entry
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.
In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.
CLA has not been signed by users: @andy-clapson
Hey @andy-clapson, thanks for the contribution! Two questions:
- Are you able to sign the CLA? If not, we won't be able to accept the changes unfortunately :( even though they're super small!
- If you are able, could you open a super quick issue for the change, just so we can track it in our changelog?
Hey @andy-clapson, thanks for the contribution! Two questions:
* Are you able to sign the CLA? If not, we won't be able to accept the changes unfortunately :( even though they're super small! * If you are able, could you open a super quick issue for the change, just so we can track it in our changelog?
Yep, done. Issue is here: https://github.com/dbt-labs/dbt-core/issues/5791
@jtcohen6 I've done all this, and added the changelog entry as well
pushed commit to address failing test - I don't want to expand the scope of this PR, but that f-string readme used in the init asserts seems like it's repeated 4 times. Could I suggest/add a refactor here of either defining a constant for it, or maybe adding it to a constants module/config?