dbt-core icon indicating copy to clipboard operation
dbt-core copied to clipboard

add favor-state flag

Open daniel-murray opened this issue 3 years ago • 7 comments
trafficstars

Co-authored-by: josephberni [email protected]

resolves #5016

Description

Add --favor-state option which enables --defer to favor using --state node even if node exists in current target.

This optionally removes the below second --defer criterion when using the --favor-state flag.

Does the reference node exist as a database object in the current environment?

Checklist

  • [ ] I have signed the CLA
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] I have added information about my change to be included in the CHANGELOG.

Currently in the process of signing the CLA.

daniel-murray avatar Apr 08 '22 15:04 daniel-murray

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @daniel-murray

cla-bot[bot] avatar Apr 08 '22 15:04 cla-bot[bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @daniel-murray

cla-bot[bot] avatar Apr 08 '22 15:04 cla-bot[bot]

@cla-bot check

ChenyuLInx avatar Apr 22 '22 14:04 ChenyuLInx

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @daniel-murray

cla-bot[bot] avatar Apr 22 '22 14:04 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 22 '22 14:04 cla-bot[bot]

Just adding a big plus one to getting this in! Any update @daniel-murray ? (Sorry for double post on issue too!)

NiallRees avatar May 02 '22 16:05 NiallRees

@daniel-murray: Is this something that you'd like to move forward?

gshank avatar Aug 11 '22 17:08 gshank

CLA has been signed off, so hoping we can get this merged soonish! Let me know if you need anything else from me.

josephberni avatar Aug 12 '22 08:08 josephberni

The first thing to do is to merge the current state of main, resolve the differences, and update.

gshank avatar Aug 12 '22 14:08 gshank

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @daniel-murray

cla-bot[bot] avatar Aug 17 '22 14:08 cla-bot[bot]

@josephberni I think we might need @daniel-murray to sign the CLA to get this merged

ChenyuLInx avatar Aug 17 '22 21:08 ChenyuLInx

I still want this real bad :D - any movement here @josephberni ?

NiallRees avatar Aug 29 '22 08:08 NiallRees

I've created a new branch for this change where I am now the owner https://github.com/dbt-labs/dbt-core/pull/5859

Let me know if there is anything else you need from me & sorry @NiallRees it took so long!

josephberni avatar Sep 16 '22 13:09 josephberni

closing in favor of https://github.com/dbt-labs/dbt-core/pull/5859

jtcohen6 avatar Sep 16 '22 14:09 jtcohen6