dbt-labs
Dockerfile should support multi-platform images
Is there an existing issue for this?
- [X] I have searched the existing issues
Current Behavior
Our newly created Dockerfile for image building supports multiple platforms through the build_for build arg.. however there is a more clever solution-- to build images that support multiple architectures utilizing multi-platform builds/manifests.
This would require a small overhaul to the build system to use buildx and some re-arranging of the dockerfile
Expected Behavior
docker pull dbt-postgres can pull the correct image based on your architecture.
Steps To Reproduce
docker pull dbt-postgres && docker run dbt-postgres --version on a non AMD64 platform.
Relevant log output
No response
Environment
- OS:
- Python:
- dbt:
What database are you using dbt with?
No response
Additional Context
This isn't a huge deal, but if we want to support M1 macs without making a separate image for them we'll have to go there eventually.
This would be a good improvement. Running the amd64 image on an M1 mac is noticeably slower because of emulation.
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is still an issue. We have changed our approach to building our own images, but I believe it should be fixed in the images provided by dbt.
Agree that this would be an improvement. Given other priorities, it's unlikely to be something we're able to prioritize in the near term.
For now, we've documented this as a fair motivation for using our Dockerfile for build a custom image, rather than using the prebuilt images: https://docs.getdbt.com/docs/get-started/docker-install#building-your-own-dbt-docker-image
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.